619: Review Board is using parameters deprecated in Django SVN

nithi******@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
Aug. 28, 2008 
What steps will reproduce the problem?
1. manage.py index


What is the expected output? What do you see instead?
I guess some kind of index file should be generated.

Traceback (most recent call last):
  File "./manage.py", line 166, in <module>
    execute_manager(settings)
  File
"/usr/lib/python2.5/site-packages/django/core/management/__init__.py", line
334, in execute_manager
    utility.execute()
  File
"/usr/lib/python2.5/site-packages/django/core/management/__init__.py", line
295, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File
"/usr/lib/python2.5/site-packages/django/core/management/__init__.py", line
249, in fetch_command
    klass = load_command_class(app_name, subcommand)
  File
"/usr/lib/python2.5/site-packages/django/core/management/__init__.py", line
67, in load_command_class
    {}, {}, ['Command']), 'Command')()
  File
"/home/nsujir/review-board/reviewboard/reviews/management/commands/index.py",
line 11, in <module>
    from reviews.models import ReviewRequest
  File "/home/nsujir/review-board/reviewboard/reviews/models.py", line 18,
in <module>
    from reviewboard.diffviewer.models import DiffSet, DiffSetHistory, FileDiff
  File "/home/nsujir/review-board/reviewboard/diffviewer/models.py", line
10, in <module>
    class FileDiff(models.Model):
  File "/home/nsujir/review-board/reviewboard/diffviewer/models.py", line
17, in FileDiff
    diffset = models.ForeignKey('DiffSet', edit_inline=models.STACKED,
AttributeError: 'module' object has no attribute 'STACKED'


What operating system are you using?
I'm using ubuntu 8.04 with reviewboard synced to latest revision. I'm using
django beta 2
chipx86
#1 chipx86 
This is more of a general problem. I'll have a fix out tonight. (Already working on it.)
  • +Started
  • -Priority-Medium
    +Priority-Furious
    +Milestone-Release1.0
  • +Review Board is using parameters deprecated in Django SVN
  • +chipx86
#2 sam****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I am having this same exact problem, just installed review board & pre-reqs on Ubuntu
8.04 -- install was a breeze, but when I run ./manage.py syncdb I get the following
errors. Please let me know when this is fixed -- I am REALLY interested in review
board and hoped to demo it at work in the next day or two. :)

user@host:~/reviewboard$ ./manage.py syncdb
Traceback (most recent call last):
  File "./manage.py", line 166, in <module>
    execute_manager(settings)
  File "/usr/lib/python2.5/site-packages/django/core/management/__init__.py", line
334, in execute_manager
    utility.execute()
  File "/usr/lib/python2.5/site-packages/django/core/management/__init__.py", line
295, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/lib/python2.5/site-packages/django/core/management/base.py", line 77, in
run_from_argv
    self.execute(*args, **options.__dict__)
  File "/usr/lib/python2.5/site-packages/django/core/management/base.py", line 95, in
execute
    self.validate()
  File "/usr/lib/python2.5/site-packages/django/core/management/base.py", line 122,
in validate
    num_errors = get_validation_errors(s, app)
  File "/usr/lib/python2.5/site-packages/django/core/management/validation.py", line
28, in get_validation_errors
    for (app_name, error) in get_app_errors().items():
  File "/usr/lib/python2.5/site-packages/django/db/models/loading.py", line 128, in
get_app_errors
    self._populate()
  File "/usr/lib/python2.5/site-packages/django/db/models/loading.py", line 57, in
_populate
    self.load_app(app_name, True)
  File "/usr/lib/python2.5/site-packages/django/db/models/loading.py", line 72, in
load_app
    mod = __import__(app_name, {}, {}, ['models'])
  File "/home/review/reviewboard/accounts/models.py", line 9, in <module>
    from reviewboard.reviews.models import Group, ReviewRequest
  File "/home/review/reviewboard/reviews/models.py", line 18, in <module>
    from reviewboard.diffviewer.models import DiffSet, DiffSetHistory, FileDiff
  File "/home/review/reviewboard/diffviewer/models.py", line 10, in <module>
    class FileDiff(models.Model):
  File "/home/review/reviewboard/diffviewer/models.py", line 17, in FileDiff
    diffset = models.ForeignKey('DiffSet', edit_inline=models.STACKED,
AttributeError: 'module' object has no attribute 'STACKED'
#3 nithi******@gmai***** (Google Code) (Is this you? Claim this profile.) 
sampost,
if you can't wait for the official fix. Just remove the undefined parameters and it
should work fine. After you remove edit_inline, you will get more errors for
core=True etc. Remove all those.
chipx86
#4 chipx86 
Meant to close this last night. It's fixed in SVN.
  • -Started
    +Fixed
#5 sam****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Yes, thanks for following up. I have pulled latest SVN and the server runs just fine.
Now trying to figure out apache integration. Thanks!

Sam