chipx86

618: Return a sane response for API calls when Review Board is not set up properly.

chipx86
chipx86
 chipx86
Sept. 20, 2009 
What's the URL of the page containing the problem?
/api/json/*

What steps will reproduce the problem?
1. Install Review Board but do not properly configure it.
2. Attempt an API call

What is the expected output? What do you see instead?
Instead of getting some valid response back, a "No JSON object could be
decoded" exception is thrown in Review Board, as it's trying to parse the
page saying how to properly set up Review Board.

We should instead hard-code an error response saying that the site is not
set up yet.
david
#1 david
  • +New
  • +-**@gmai***** (Google Code)
david
#2 david
  • -New
    +Confirmed
chipx86
#3 chipx86 
Downgrading the severity, since with rb-site, new sites should always be set up
properly. May end up pushing this to the next release.
  • -Priority-Critical
    +Priority-High
chipx86
#4 chipx86 
Yeah, less important for now. Pushing it back.
  • -Priority-High
    -Milestone-Release1.0
    +Priority-Low
    +Milestone-Release1.5
chipx86
#5 chipx86 
This was actually fixed some time ago. For 1.0, it turns out. Guess I forgot.
  • -Confirmed
    +Fixed
  • -Milestone-Release1.5
    +Milestone-Release1.0
  • --**@gmai***** (Google Code)
    +chipx86