615: Tab order for add comment, publish review dialog could be better

nithi******@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
Dec. 27, 2008
What steps will reproduce the problem?
1. Open the comment dialog and type a comment.
2. Press tab.
3. The 'Cancel' button is highlighted.
4. Press tab again. Now the 'Save' button gets focus and you can press enter. 
5. Press Shift-Tab. Now the 'Close' button is highlighted and you can press
enter to close the dialog.

What is the expected output? What do you see instead?
Would be nice if the first tab went to the 'Save' button and the next tab
went to the 'Close' button.

What operating system are you using? What browser?
Winxp, ffox 3
david
#1 david
Christian, can you pay attention to this in your jQuery rewrite?
  • +Started
  • +chipx86
chipx86
#2 chipx86
Yep, due to the new simplified dialog, this is fixed in the UI rewrite.
  • +Milestone-Release1.0
    +Keyboard
    +Usability
    +Component-DiffViewer
chipx86
#3 chipx86
Fixed in r1644.
  • -Started
    +Fixed