614: Very poor performance with diffs against large files

email.*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Oct. 20, 2008 
When trying to view a review request that has a small diff (around 5 lines)
against a very large file (1,2MB), the performance is very poor taking more
than a minute to display the review request page.

We are running reviewboard using an slightly underpowered virtual machine,
but most review request pages open in 2, 3 seconds.

During this time, the server is using 100%CPU and the apache server memory
usage rises to 160MB.


Anything I can do to help track this problem?
#1 email.*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
(Forgot this in the problem description)

This happens with a svn checkout from two hours ago.
#2 ciao****@gmai***** (Google Code) (Is this you? Claim this profile.) 
We're having this same issue with large diffs. (we use perforce). CPU is at 100% for 
a few minutes.
david
#3 david
  • +Confirmed
david
#4 david 
A lot of this should be fixed now that we properly cache files > 1M, so you'll only
get the performance hit once. There's still more optimization to do, but specific
issues will be tracked individually in their own bugs.

Note that syntax highlighting takes a lot of CPU power (pygments isn't the fastest
thing in the world). If you've got a lot of very large files to review, consider
turning off syntax highlighting in your user preferences.

I'm going to call this bug fixed due to the cache issues involved.

Thanks!
  • -Confirmed
    +Fixed