610: cvs follows .cvsrc and cat_file() fails due to this

lamo*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Aug. 29, 2008 
What steps will reproduce the problem?
1. create ~/.cvsrc file with cvs -q
% cat ~/.cvsrc
cvs -q

2. view diff with browser on remote server

What is the expected output? What do you see instead?
Raises FileNotFoundError at line 189 of scmtools/cvs.py

Working patch is attached.
cvs.patch 
Index: cvs.py
===================================================================
--- cvs.py	(revision 1424)
+++ cvs.py	(working copy)
@@ -157,7 +157,7 @@
         if filename.endswith(",v"):
             filename = filename.rstrip(",v")
 
-        p = subprocess.Popen(['cvs', '-d', self.repository, 'checkout',
+        p = subprocess.Popen(['cvs', '-f', '-d', self.repository, 'checkout',
                               '-r', str(revision), '-p', filename],
                              stderr=subprocess.PIPE, stdout=subprocess.PIPE,
                              close_fds=True)
chipx86
#1 chipx86 
Can you please put this up on http://reviews.review-board.org/ ?
  • -Priority-Medium
    +Priority-High
    +Component-SCMTools
    +Milestone-Release1.0
#2 lamo*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
done @ http://reviews.review-board.org/r/518/
david
#3 david 
Fixed in SVN r1474. Thanks!
  • +Fixed