607: post-review option to insert the review url into the changelist description
- Fixed
- RBTools
| nithi******@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| 1503 |
Describe the enhancement and the motivation for it. I'm not sure this is the best way to do this. When a perforce change is submitted for review, it would be nice if the review url is added automatically into the description if it doesn't exist already. At a later time, this would be convenient to find the review. This could be implemented relatively easily I assume using p4python. What operating system are you using? What browser? Winxp , Ffox 3 Thanks, Nithin.
-
+ Confirmed
-
- Confirmed + Started -
+ Component-Scripts + PendingReview
I see that there's a patch out on this (http://reviews.review-board.org/r/527/) but it looks a bit abandoned. If so I'd be happy to pick it up since we'd like to add these fields to our checkin templates soon. As trowbrds mentioned in the review, it'd be nice if post-review could either add a Review URL field if it was missing or fill in an existing one for organizations that have a checkin template that they populate on their own. It would also be good if this could be configured to do nothing, as some places with more strict processes can get pretty picky about their forms. I'd also like to do a similar "Review Number" or "Review Board ID" option which has just the review ID instead of the URL. On the one hand, the URLs are more immediately useful and contain the review number anyway. On the other hand, URLs can be kind of brittle as infrastructure and hostnames change, and just using ID numbers is more consistent with how we (and I think other folks) treat bugs.
-
- Type-Defect + Type-Enhancement
-
- Component-Scripts + Component-RBTools
-
+ Project-RBTools
This is an old issue, but I'm posting because it's something I want to do. I've currently got a patch under review to add perforce support for 'rbt stamp' (https://reviews.reviewboard.org/r/7153/), and once that's finished, I'll submit another to auto-stamp while posting. Mine doesn't support custom tag names, but I could see that being an extension in the future.
