600: Add save buttons to modifiable request fields
- Fixed
- Review Board
| sean*****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
 |
|
| Dec. 27, 2008 |
http://reviews.review-board.org/ What's the URL of the page this enhancement relates to, if any? http://reviewboard.host.com/r/#/ Describe the enhancement and the motivation for it When modifying single line fields in a review (e.g. Summary, Branch, or bugs) the user must press return to save any changes. If enter is not pressed and the user leaves the review, the changes are not saved. This is inconsistent with the multi-line fields which include save and cancel buttons. Similar buttons should be added for the single line fields. What operating system are you using? What browser? Windows (Both server and browser) and Firefox 3
We used to have them and a lot of people complained.
What did they complain about? It makes sense to have enter to save on the single lines, but I can't see why people would complain about the presence of buttons so I must be missing something. The reason I bothered to file this at all is that I've had two people get stuck in this spot as we're rolling this out to the team. From a UI perspective, there's no clear indication of what the user needs to do to save the changes.
People got really confused thinking that if they pressed OK/Save on one of these fields that it implied Publish. Doesn't make any sense, really. I'll have to look up the bug reports and think about bringing these back.
-
- Type-Defect + Type-Enhancement + Component-Reviews
In earlier versions was there a big green bar with a Publish button being the obvious way to publish? I'm more confused by the inconsistency of the fields. See http://code.google.com/p/reviewboard/issues/detail?id=497#c2 The summary field with unsaved changes looks identical to the Description field with saved changes. I would recommend standard green check (save) and red cross (discard) at the end of the unsaved fields.