586: Publishing draft of comment shows error.

Last****@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 10, 2009
What's the URL of the page containing the problem?
http://reviewboard.vidsolbach.de/r/131/

What steps will reproduce the problem?
1. Write a reply comment draft.
2. Attempt to publish.
3. An error pops up saying error saving. (See below)

What is the expected output? What do you see instead?
Expected:  The draft is succesfully saved and published.

Error:
Saving the reply draft has failed due to a server error.. Please try again
later. If this continues to happen, please report it to your administrator

What operating system are you using? What browser?
openSUSE 11 Linux (2.6 kernel), Mozilla Firefox 3.0.1

Please provide any additional information below.
david
#1 david
It's a bit of a pain, but could you install firebug and get a traceback for this
error? At the moment there isn't enough information to know what went wrong.

Thanks
  • +NeedInfo
#2 cas****@gmai***** (Google Code) (Is this you? Claim this profile.)
We are having the same issue. The error is displayed, however the comments are 
actually added.

The error happens when 'function submitReplyDraft(review_id)' is invoked.

The async json POST request fails and showServerError prints the error message 
indicated above.

I'm not a jscript programmer and it's hard for me to find out what happens inside the 
obfuscate yahoo code. If you provide some directions I might be able to find out 
more.
#3 cas****@gmai***** (Google Code) (Is this you? Claim this profile.)
The same error is produced when publishing comments through the diff view. The 
following message appears next to the publish button in the comment popup window:

"Internal Server Error"
#4 cas****@gmai***** (Google Code) (Is this you? Claim this profile.)
This seems to have something to do with the email settings not setup properly. If the 
mail server returns an error, then the client doesn't display a meaningful message, 
instead it displays the internal server error described above.
david
#5 david
That's helping to narrow it down, but to really debug this, we still need a traceback.
#6 kaz***@gmai***** (Google Code) (Is this you? Claim this profile.)
In our environment, this problem seems to appear when some Japanese characters  are
included in the comment.
#7 lej***@gmai***** (Google Code) (Is this you? Claim this profile.)
When using swedish chars, I hit this bug.

here is the POST respone when trying to send "åäö" as a diff comment (some
confidential information removed) which results in "Internal Server Error":

{"stat": "ok", "comments": [{"interfilediff": null, "num_lines": 1, "text":
"\u00e5\u00e4\u00f6", "timesince"
: "0 minutes", "public": 0, "user": {"username": "tony", "first_name": "Tobias",
"last_name": "Nystr\u00f6m", "url": "/users/tony/", "email": "email@email.com",
"fullname": "Tobias Nystr\u00f6m", "id": 2}, "timestamp": "2008-12-05 09:45:47",
"first_line": 8, "id": 16, "filediff": {"diffset": {"timestamp": "2008-12-04
17:08:53", "revision": 1, "id": 6, "repository": {"path": "perforce:1666", "tool":
"Perforce", "id": 1, "name": "Perforce Server"}, "name": "diff"}, "dest_detail":
"2008-12-01 17:44:01", "source_revision": "1", "source_file": "//source/file.h",
"dest_file": "//source/file.h", "id": 7}}]}

Note that I have the char "ö" in my last name aswell, that is hasn't produced any
problem.
#8 lej***@gmai***** (Google Code) (Is this you? Claim this profile.)
And the postdata was:

action=set&num_lines=1&text=%C3%A5%C3%A4%C3%B6%0A&dummy
david
#9 david
Can you get a traceback for this?
#10 kaz***@gmai***** (Google Code) (Is this you? Claim this profile.)
In my case, the cause was invalid character code setting in the MySQL database. 
Somehow it was set to latin-1, but should be utf-8.

I remedied it with ALTER TABLE command (in mysql admin shell).
david
#11 david
Charsets in MySQL are hard to configure correctly :(
  • -NeedInfo
    +UserError