572: 404 when discarding draft diff from diff viewer

dbe****@gmai***** (Google Code) (Is this you? Claim this profile.)
Sept. 23, 2008
What's the URL of the page containing the problem?
Probably not needed, but what the hell:
http://reviewboard.eng.vmware.com/r/36137/diff/3-4/

What steps will reproduce the problem?
1. Use post-review to post a new version of a diff for a review that
already exists.
2. View the diff between previous version and new (draft) version.
3. Click Discard Draft.
4. 404 error.

I didn't check if this happens if viewing actual diff (not inter-diff diff).
#1 dbe****@gmai***** (Google Code) (Is this you? Claim this profile.)
This happens when viewing the new diff itself too. Eg:
http://reviewboard.eng.vmware.com/r/36362/diff/4/#index_header
chipx86
#2 chipx86
Could be that you weren't logged in when trying to go back to the diff. Can you still
reproduce this?
  • +NeedInfo
#3 dbe****@gmai***** (Google Code) (Is this you? Claim this profile.)
I'm pretty sure I was logged in when trying to go back. I can't reproduce it now
though. If I use post-review to upload a new version of a diff and I'm viewing the
diff and discard the draft, it works correctly. I don't see the option to diff the
draft against the previous version of the diff any more, so I can't test it from
there. Why would that be?

FWIW, I'm using a local copy of post-review. I had to change some small thing
although I don't remember what any more.
david
#4 david
Assuming fixed.
  • -NeedInfo
    +Fixed