563: Add a way to collapse old reviews
- Fixed
- Review Board
| dbe****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Nov. 7, 2010 |
I'm not sure if "review" is the right word, but the idea is that if I'm on a review page and someone's reviewed the diff, maybe we've had some back and forth, and I'm done dealing with what they've said, I'd like to be able to collapse or hide their review. There may be other reviews below and now I need to scroll past the earlier one(s) when I load the page to see the relevant information. This is especially likely if I've posted a new version of the diff and the older comments don't apply any more. What operating system are you using? What browser? Kubuntu 8.04. Firefox 3. (Just in case this is there and I'm not seeing it.)
I like this idea. We could even do it automatically after a diff is updated (maybe toggleable as a preference). Probably post-1.0 material though.
-
- Type-Defect + Type-Enhancement + Milestone-Release2.0 + Component-Reviews + Usability + Settings
I think "comment" may be a better word than review. I like this idea, too. I'd like to hear what others think about it, since I think there are a variety of things that could be done. On a large review with a lot of comments, it starts to generate a lot of noise when you have to scroll through pages of comments, many of them no longer relevant. Some thoughts/questions: - Would "hiding" a set of comments be seen only by the current user, or would it hide them for everyone looking at the review? - As a reviewer, I sometimes find it difficult to ensure that all my comments get addressed, especially if I make a large number of comments. Code Collaborator (and probably other tools) have features to open "defects" or "todo" items on a review, which have state. When the author addresses a change and posts an update, they can "close" the defects. This would give a reviewer a chance to "verify" the closed defects. This would give a clear process for dealing with issues (can't be submitted until all issues are closed and verified, for exmaple). Then, closed issues can be hidden and would keep the review tidy. OTOH, this is pretty heavyweight and bureaucratic, and I'm not sure that fits with your vision.
Comment is better, although it's really an aggregation of one person's comments about one version of the diff. I think the hiding should be on a person by person basis, although if there are sensible default changes, such as hiding a set of comments when a new version is posted, that should affect everyone. I think comment tasks might be useful as well. It's kind of a separate feature, but it might interact with the hiding feature by hiding threads when they're closed.
Yeah, comment tasks are a different issue (and I believe we have a bug for it). I need to give more thought to how we'll want to do this feature, but regardless, collapsed reviews will be able to be expanded in case the user didn't want it collapsed. We won't actually hide it from view. It'll appear as a little bar with a "+" or something.
-
- Settings + Component-Settings
-
+ Confirmed
Hi Guys, I think this would be a really nice feature. What would be ideal for me personally would be if I could set a preference to "Only show comments for the current diff revision", or something like that. Being able to toggle the boxes would be handy, so maybe this user preference would automatically toggle boxes for comments that aren't for the current diff revision? Just a thought.
This is in master revision 671c0c7 now. Thanks to Kevin Quinn for taking this on :)
-
- Confirmed + Fixed