560: Indicate line termination

cor****@gmai***** (Google Code) (Is this you? Claim this profile.)
Oct. 11, 2009 
reviewboard seems to completely ignore changes in line termination even
though the changes in the svn repository do show the line termination as
changing.

For me this would be a much more useful use of big bold red at the end of
line rather than showing it for trailing whitespace which can be shown in
other ways.

Another idea is to pick the line ending most typically used in the file CR
or CRLF and highlight when the line ending is different.  Indicate the
expected line ending in a header or footer for each file.
chipx86
#1 chipx86
  • -Type-Defect
    +Type-Enhancement
    +Component-DiffViewer
david
#2 david
  • +Confirmed
chipx86
#3 chipx86 
This would actually be a *lot* of work and add overhead to the diff viewer, and while
I can see it being useful, I think it's only useful in a few situations under just
the right conditions. We'd have to replace all of our newline normalization code in
both post-review and Review Board's diff viewer, and doing this would likely regress
us quite a bit.

So after further thought, I'm going to have to say no to this one. Too much effort
and chance of breakages for too little reward.
  • -Confirmed
    +WontFix