556: diffviewer.js Incorrect URL

thin****@gmai***** (Google Code) (Is this you? Claim this profile.)
Aug. 2, 2008
What's the URL of the page containing the problem?
http://demo.review-board.org/r/707/diff/

What steps will reproduce the problem?
Any diff view

What is the expected output? What do you see instead?
When you put mouse on a line without comments, it should display comment-
ghost.png, however the url is wrong and this image is missing.

What operating system are you using? What browser?
Windows XP, Opera and IE7 tested

Please provide any additional information below.
Index: htdocs/media/rb/scripts/diffviewer.js
===================================================================
--- htdocs/media/rb/scripts/diffviewer.js       (revision 1414)
+++ htdocs/media/rb/scripts/diffviewer.js       (working copy)
@@ -657,7 +657,7 @@
                 gGhostCommentFlag = dh.append(document.body, {
                     id: 'ghost-commentflag',
                     tag: 'img',
-                    src: '../images/comment-ghost.png'
+                    src: MEDIA_URL + 'rb/images/comment-ghost.png'
                 }, true);
                 gGhostCommentFlag.enableDisplayMode();
                 gGhostCommentFlag.setAbsolutePositioned();
david
#1 david
Fixed in r1425. Thanks!!
  • +Fixed