552: Provide a template for the Testing Done and Description sections

mladen******@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 4, 2014
This is not a bug actually, but a question (or feature request). Is there a
way to define a template for testing done section which people should fill
in before publishing the review request?

Thanks,
MB
chipx86
#1 chipx86
There is not but it's something that could be added. Not sure whether we'll get to it
for 1.0 or not, but it's probably going to be easy with the new settings stuff.

I'm going to go a step further and say we should have this for both Testing Done and
Description.
  • -Type-Defect
    +Type-Enhancement
    +Component-Reviews
  • +Provide a template for the Testing Done and Description sections
#2 kevin.******@beatpo****** (Google Code) (Is this you? Claim this profile.)
While we're at it, why not add ability to make description and testing done required
fields?
chipx86
#3 chipx86
We could do that. It's one of those policy decisions I don't want to set globally in
Review Board, because it doesn't always make sense to put something in Testing Done,
but once the new site configuration code is in we can start letting people specify
things like this.

It's a 1.5 feature at the earliest, though, as we're trying to limit what new
features we accept for 1.0 so we can actually get a release out.
  • +Milestone-Release1.5
david
#4 david
  • +Confirmed
chipx86
#5 chipx86
  • +Milestone-Release1.6
chipx86
#6 chipx86
  • +Priority-Low
chipx86
#7 chipx86
  • -Milestone-Release1.6
#9 adir*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Just a quick hack to add a default text in case the review has not description.

In reviewboard/templates/reviews/new_review_request.html

change

<pre id="description" class="editable">{{review_request_details.description|escape}</pre>

with

  <pre id="description" class="editable">{% if review_request_details.description %}{{review_request_details.description|escape}}{% else %} YOUR TEMPLATE TEXT HERE {% endif %}</pre>

Maybe you can also use include to put the text as an external file

{% include "reviews/review_description_template.html" %}
david
#10 david
  • -Confirmed
    +WontFix