550: Can not put comments before publishing review

ksan****@gmai***** (Google Code) (Is this you? Claim this profile.)
Dec. 28, 2008 
What steps will reproduce the problem?
1. Post a review
2. Try to post a comment on any line

What is the expected output? What do you see instead?
Not able to post a comment. When "Save Comment" button is pressed message
"Not Found" is displayed at the bottom of Comments window but nothing happens.

What operating system are you using? What browser?
Red Hat Linux
Firefox

Please provide any additional information below.
chipx86
#1 chipx86 
Make sure you're logged in and that the review request is published.
  • +NeedInfo
david
#2 david 
Uhh, Christian, read the summary?
chipx86
#3 chipx86 
I did. The suggestions still apply. If you're not logged in, you can get the "Not
Found," and if you're logged in but the review request has been discarded, you can
also get it.
#4 jeremy*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
Could the NOT FOUND text be changed to "YOU ARE NOT LOGGED IN" or "THIS REVIEW HAS
NOT BEEN PUBLISHED"
chipx86
#5 chipx86 
Yeah, I think what we need to do is either show a login form or a link to the login
page when the user isn't logged in. We definitely need to show something when the
review hasn't been published as well. I'd like to get to this for 1.0.
  • -NeedInfo
    +Accepted
  • +Milestone-Release1.0
david
#6 david
  • -Accepted
    +New
david
#7 david 
I've definitely seen this, even when the user in question is logged in.
  • -New
    +Confirmed
chipx86
#8 chipx86 
I don't think we'll see this anymore, since the entire codebase for commenting has
been completely rewritten, as has the UI, and some operations that may have caused
this in the first place are gone. The code for saving comments has also become a bit
more bullet-proof.

I'm going to close this. Please reopen if it happens with the new UI.
  • -Confirmed
    +Fixed