55: Diff errors when creating a new review request shouldn't leave a stale review request

chipx86
david
david
June 6, 2007
What's the URL of the page containing the problem?
/r/new/

What steps will reproduce the problem?
1. Fill out the form and upload an invalid diff
2. See the exception
3. Notice how the review request still exists.

What is the expected output? What do you see instead?
While this isn't horrible, as you can go and re-upload to the review
request itself, we should probably just nuke the review request and display
an error.
david
#1 david
Fixed in svn.
  • +Fixed
  • +david