548: web services doesn't strip newline from summary. new lines in summary cause publish to fail

jaybuf*******@gmai***** (Google Code) (Is this you? Claim this profile.)
david
 david
Sept. 30, 2008 
I was able to create a review request that had a summary which contained new lines.  When the 
reviewer did a review and said "ship it" the publish failed.  I've attached the output of the failure 
which shows django's debug page.  

Jay
rb-publish-fail.html 
<html lang="en">
<head>
  <meta http-equiv="content-type" content="text/html; charset=utf-8">
  <meta name="robots" content="NONE,NOARCHIVE">
  <title>BadHeaderError at /api/json/reviewrequests/144/reviews/draft/publish/</title>
  <style type="text/css">
    html * { padding:0; margin:0; }
    body * { padding:10px 20px; }
    body * * { padding:0; }
    body { font:small sans-serif; }
    body>div { border-bottom:1px solid #ddd; }
    h1 { font-weight:normal; }
    h2 { margin-bottom:.8em; }
    h2 span { font-size:80%; color:#666; font-weight:normal; }
    h3 { margin:1em 0 .5em 0; }
    h4 { margin:0 0 .5em 0; font-weight: normal; }
    table { border:1px solid #ccc; border-collapse: collapse; width:100%; background:white; }
    tbody td, tbody th { vertical-align:top; padding:2px 3px; }
    thead th { padding:1px 6px 1px 3px; background:#fefefe; text-align:left; font-weight:normal; font-size
:11px; border:1px solid #ddd; }
    tbody th { width:12em; text-align:r

 






  


 










 

   

 
 

  

    
     

   
   #1
   jaybuf*******@gmai***** (Google Code)



(Is this you? Claim this profile.)


  


  
Sorry, i forgot to mention i created the review request via web services.



 








 

  

   chipx86

  

 
 

  

    
     

   
   #2
   chipx86


  


  
We should either normalize the input, or send an error message.



  
    


   
  • 
    
    
    +Milestone-Release1.0
    +Component-API
    
   
    • 


  


 








 

  

   david

  

 
 

  

    
     

   
   #3
   david


  



  
    


   
  • 
    
    
    +Started
    
   
    • 



   
  • 
    
    
    +david
    
   
    • 


  


 








 

  

   david

  

 
 

  

    
     

   
   #4
   david


  


  
Fixed in SVN r1520. Thanks!



  
    


   
  • 
    
    
    -Started
    +Fixed
    
   
    •