543: post-review not working under Windows with SVN

mate.******@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
Sept. 23, 2008 
Locale fix (r1390) breaks windows compatibility.

r1390 makes post-review unusable for svn under windows.
It was reviewed here:
http://reviews.review-board.org/r/419/

What steps will reproduce the problem?
Try to use a post r1390 post-review under windows.

What is the expected output? What do you see instead?

It's expected to work:)
It'll fail "silently" instead with:
"The current directory does not contain a checkout from a
supported source code repository."

After adding some debugging:
"'env' is not recognized as an internal or external command,
operable program or batch file."
#1 mate.******@gmai***** (Google Code) (Is this you? Claim this profile.) 
I think the solution is simple.
Simply revert all the changes made in r1390.
chipx86
#2 chipx86 
Pending review at http://reviews.review-board.org/r/515/
  • -Priority-Medium
    +Priority-Critical
    +Milestone-Release1.0
    +PendingReview
    +Component-Scripts
  • +chipx86
chipx86
#3 chipx86 
Fixed in r1455.
  • +Fixed
  • -PendingReview
#4 andrewhagu**********@gmai***** (Google Code) (Is this you? Claim this profile.) 
The version at r1388 works for me but r1455 does not work.

I'm using SVN for source control.

It fails with '
Error uploading diff: One or more fields had errors (105)
Your review request still exists, but the diff is not attached.
'

with --debug '
Error uploading diff: One or more fields had errors (105)
>>> {u'fields': {u'path': [u'The diff file is empty']}, u'stat': u'fail', u'err'
: {u'msg': u'One or more fields had errors', u'code': 105}}
Your review request still exists, but the diff is not attached.
'
chipx86
#5 chipx86 
That's a separate bug most likely.

What happens when you run with --output-diff?
  • -Fixed
    +NeedInfo
david
#6 david 
Looks different.  Please open another bug with the details (if you can).
  • -NeedInfo
    +Fixed