538: Review emails need to contain info about the line number where the comment is

stanim*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Aug. 5, 2008
The format of the reviews items that we see in the e-mails is like this:

//depot/........../FileName.cs
<http://reviewboard.eng.vmware.com/r/34031/#comment166920>

Some comments on the particular like or group of lines.


This is ok most of the cases. Sometimes a reviewer can send a review and
then the reviewboard server may go down. It will be really helpful if the
line in the file which the comment refers to is also send as info in the
e-mail. This way we can act on reviews if the reviewboard server itself is
down. Otherwise it is pretty hard to guess for which line the comment is
especially if you receive a lot of comments on a single file
#1 emil****@gmai***** (Google Code) (Is this you? Claim this profile.)
Yes, it'd be nice to be able to highlight that your comment applies to a number of
lines and then have those selected lines appear in the review e-mails, with context.
It's easy to do this when e-mailing (unified) diffs around because you just cut out
the parts you don't want and quote the parts you do.
david
#2 david
This is already tracked in issue 132.
  • +Duplicate
  • +Component-EMail
  • +Review emails need to contain info about the line number where the comment is