531: feature request - can "submitted" be set automatically?
- Duplicate
- Review Board
| j**@divisionb********* (Google Code) (Is this you? Claim this profile.) | |
| July 8, 2008 |
reviewboard has a change number and a repository name in my diff, so why do i need to manually check the "submitted" box when my code is submitted? perforce supports triggers on submit (a certain virtualization company uses such a trigger for p4->bugzilla notification) so it'd be nice to harness this for reviewboard as well. from perforce i think you'd only need the repository name:port (aka P4PORT) and change number to uniquely identify the corresponding diff in reviewboard. -jon
issue 294 seems similar but the suggested workarounds are based on reviewboard polling p4. i think my suggestion would be easier in the long run.
We can do this at VMware, yes, but this is not automatic in all systems so there must always be a manual way of submitting. People have written hook scripts for SVN to do this, and we've discussed doing it with Perforce at VMware (I assume you're from VMware based on your comments), but we haven't decided to do it to my knowledge. There's a technical reason why this is hard. First, changes get new changenumbers when submitted. In order to properly know that a change was submitted, we'd need deeper hooks to let us know not only of the submit, but of the new changenumber as well. This requires a bit more work to set up and better hooks into our existing scripts (such as p5). Even if we got all this set up, it'd be somewhat unique to our company. Lots of companies use Review Board, so we must make sure to not build things into the codebase that are specific to a particular install. This is why we can never get rid of Set Submitted, even if we automated it for our setup. So it's a bit harder than just having a trigger. We'll figure out what we're doing with this in time but right now, you have to click Set Submitted.
