523: Hitting escape when entering a new comment on a diff moves to the top of the page

grossag
chipx86
chipx86
Dec. 27, 2008
What's the URL of the page containing the problem?
Any review

What steps will reproduce the problem?
1. Create a new comment on any diff
2. Hit escape

What is the expected output? What do you see instead?
I expect it to hide the comment but leave the view on the same area of the
diff.  Instead, it does hide the comment but then performs the equivalent
of hitting the Home key; it moves to the top of the page.

What operating system are you using? What browser?
XP SP2 with Firefox 3

Please provide any additional information below.
jameslin
#1 jameslin
I've been bitten by this several times.
chipx86
#2 chipx86
  • +Milestone-Release1.0
    +Component-DiffViewer
    +EasyFix
david
#3 david
This should hopefully get fixed with Christian's jQuery refactor.
  • +Started
  • +chipx86
chipx86
#4 chipx86
Fixed in r1644.
  • -Started
    +Fixed