What's the URL of the page containing the problem?
internal...
What steps will reproduce the problem?
1. Submit a diff from cvs 1.11.17
2. Try to view the diff
3.
What is the expected output? What do you see instead?
I expect to see a diff, instead I see:
Traceback (most recent call last):
File "/home/wlentz/reviewboard/reviewboard/diffviewer/views.py", line 82,
in view_diff
files = get_diff_files(diffset, None, interdiffset, highlighting)
File "/home/wlentz/reviewboard/reviewboard/diffviewer/diffutils.py", line
594, in get_diff_files
enable_syntax_highlighting)
File "/home/wlentz/reviewboard/reviewboard/diffviewer/diffutils.py", line
513, in generate_files
lambda: get_chunks(filediff.diffset,
File "/home/wlentz/reviewboard/reviewboard/djblets/util/misc.py", line
49, in cache_memoize
data = lookup_callable()
File "/home/wlentz/reviewboard/reviewboard/diffviewer/diffutils.py", line
516, in <lambda>
enable_syntax_highlighting))
File "/home/wlentz/reviewboard/reviewboard/diffviewer/diffutils.py", line
316, in get_chunks
old = get_original_file(filediff)
File "/home/wlentz/reviewboard/reviewboard/diffviewer/diffutils.py", line
223, in get_original_file
data = cache_memoize(key, lambda: [tool.get_file(file, revision)])[0]
File "/home/wlentz/reviewboard/reviewboard/djblets/util/misc.py", line
49, in cache_memoize
data = lookup_callable()
File "/home/wlentz/reviewboard/reviewboard/diffviewer/diffutils.py", line
223, in <lambda>
data = cache_memoize(key, lambda: [tool.get_file(file, revision)])[0]
File "/home/wlentz/reviewboard/reviewboard/scmtools/cvs.py", line 35, in
get_file
return self.client.cat_file(path, revision)
File "/home/wlentz/reviewboard/reviewboard/scmtools/cvs.py", line 154, in
cat_file
raise FileNotFoundError(filename, revision)
FileNotFoundError: The file 'stinger/app/dspregs.h' (r1.66) could not be
found in the repository
What operating system are you using? What browser?
Linux for running review-board, Firefox for viewing
Please provide any additional information below.
The following change fixes the problem (remvoe the "-q" to CVS):
Index: cvs.py
===================================================================
--- cvs.py (revision 1385)
+++ cvs.py (working copy)
@@ -122,7 +122,7 @@
self.tempdir = tempfile.mkdtemp()
os.chdir(self.tempdir)
- p = subprocess.Popen(['cvs', '-q', '-d', self.repository, 'checkout',
+ p = subprocess.Popen(['cvs', '-d', self.repository, 'checkout',
'-r', str(revision), '-p', filename],
stderr=subprocess.PIPE, stdout=subprocess.PIPE,
close_fds=True)
