510: spaces break post-review (at least for svn)
- Fixed
- Review Board
| travis******@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| July 30, 2008 |
What steps will reproduce the problem?
attempt to 'post-review (path with a space)'
What is the expected output? What do you see instead?
- normal operation
- failures for svn diff and svn info
Index: post-review
===================================================================
--- post-review (revision 1385)
+++ post-review (working copy)
@@ -711,7 +711,7 @@
def svn_info(self, path):
"""Return a dict which is the result of 'svn info' at a given path."""
svninfo = {}
- for info in execute("svn info " + path).splitlines():
+ for info in execute("svn info '%s'" % path).splitlines():
parts = info.split(": ", 1)
if len(parts) == 2:
key, value = parts
@@ -1527,6 +1527,7 @@
diff = tool.diff_between_revisions(options.revision_range)
parent_diff = None
else:
+ args = ["'%s'" % arg for arg in args] # quote filenames
diff, parent_diff = tool.diff(args)
if options.output_diff_only:
Index: post-review
===================================================================
--- post-review (revision 1413)
+++ post-review (working copy)
@@ -711,7 +711,7 @@
def svn_info(self, path):
"""Return a dict which is the result of 'svn info' at a given path."""
svninfo = {}
- for info in execute("env LANG=en_US.UTF-8 svn info " + path).splitlines():
+ for info in execute("env LANG=en_US.UTF-8 svn info '%s'" % path).splitlines():
parts = info.split(": ", 1)
if len(parts) == 2:
key, value = parts
@@ -1528,6 +1528,7 @@
diff = tool.diff_between_revisions(options.revision_range)
parent_diff = None
else:
+ args = ["'%s'" % arg for arg in args] # quote filenames
diff, parent_diff = tool.diff(args)
if options.output_diff_only:
Can you put this up on http://reviews.review-board.org/ ? It's easier for us to keep track of it. Thanks
up as 470
