506: Post-review session not permanent
- Fixed
- Review Board
francois********@eures****** (Google Code) (Is this you? Claim this profile.) | |
June 9, 2008 |
What steps will reproduce the problem? 1. Use a clean system or remove .post-review-cookies.txt 2. Send a review with post-review. You will need to login. 3. Send another review with post-review What is the expected output? What do you see instead? post-review should ask to login only once. What operating system are you using? What browser? Debian 4.0 and Windows XP. Firefox 2.0. Please provide any additional information below. In debug mode, post-review says "Cookie file loaded, but no cookie for this server"
After some debugging, I discovered that post-review fails to find the correct cookie in the file. The cookie sent by Review Board is "rbsessionid" while post-review tries to fetch the "sessionid" cookie. Changing the line cookie = self.cookie_jar._cookies[host][path]['sessionid'] to cookie = self.cookie_jar._cookies[host][path]['rbsessionid'] fixes the problem.