jgagnon

5034: Updating an existing review with a change that deletes lines will not show up in an interdiff

jgagnon 
What version are you running?


7.0.3


What's the URL of the page containing the problem?


https://reviewboard.foo.com/r/40645/diff/1-2#1


What steps will reproduce the problem?


    

  1. rbt post a new review and publish it
    2. 

  2. delete a line from one of the files you modified in your initial post
    3. 

  3. rbt post to update the review
    4. 

  4. Look at the the diff from just version 1 to version 2
    5. 



What is the expected output? What do you see instead?


I expect to see a red diff where the deleted line is shown. Instead the file says "Only whitespace changes" and does not highlight the removed line. If I expand the view and scroll I can see the line present in 1 and removed in 2, but there is no highlighting of this and zero chance I'd find it if I didn't know what to look for.


When viewing the "entire" diff (from 0-2 in this simple case) the deleted line does show up correctly.


What operating system are you using? What browser?


Ubuntu 22.04.1

Google Chrome - Version 131.0.6778.264 (Official Build) (64-bit)


Please provide any additional information below.