4962: Source diff between revisions of Markdown attachment no longer works

rbsurfer 
What version are you running?


4.0.4


What's the URL of the page containing the problem?


http://reviewboard/r/40587/file/14050-14052/#source


What steps will reproduce the problem?


    

  1. Create a Markdown file called test.md with any content, create a review request with it as an attachment, and post it
    2. 

  2. Make any change to test.md, update the attachment on the review request, and post it
    3. 

  3. View test.md in Review Board and use the revisions slider to view the diff between revisions 1 and 2
    4. 

  4. Click the "Source" tab
    5. 



What is the expected output? What do you see instead?


Actual behaviour: nothing happens when you click "Source".


Expected behaviour is you see a diff of the sources. This works in RB 2.5.16. (I don't have any other versions to test with so can't be more specific about when it broke, sorry.)


What operating system are you using? What browser?


Windows, Firefox and Chrome


Please provide any additional information below.
#1 rbsurfer 
So I wasn't all that hopeful, what with the non-acknowledgement of this ticket. But the release notes for v4.0.10 say: "Fixed switching between Source and Rendered modes when reviewing Markdown files."


And testing in v4.0.11 shows this is indeed fixed. Thanks, guys!
david
#2 david
  • -New
    +Fixed