480: Can no longer publish review requests as of r1337

christo********@gmai***** (Google Code) (Is this you? Claim this profile.)
david
 david
Aug. 27, 2008 
I see r1337 made a change to stop draft review requests from being
accessible to others.

However, now I cannot publish a review request at all.

Reverting to r1336 works.


What steps will reproduce the problem?
1. Create a review request
2. Enter basics (description, summary, reviewer)
3. Hit "Publish"

What is the expected output? What do you see instead?
The review should be published

What operating system are you using? What browser?
Firefox 3b5 on OS X 10.5, with Ubuntu 8.04 server.

Please provide any additional information below.
Python 2.5.2
Django r7514
Review Board r1344


Stack trace upon pressing "Publish" on the draft review request:

Environment:

Request Method: GET
Request URL: http://reviewboard:8080/r/1/publish/
Django Version: 0.97-pre-SVN-unknown
Python Version: 2.5.2
Installed Applications:
['django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.markup',
 'django.contrib.sites',
 'django.contrib.sessions',
 'djblets.datagrid',
 'djblets.util',
 'djblets.webapi',
 'reviewboard.accounts',
 'reviewboard.admin',
 'reviewboard.diffviewer',
 'reviewboard.iphone',
 'reviewboard.reports',
 'reviewboard.reviews',
 'reviewboard.scmtools',
 'reviewboard.webapi']
Installed Middleware:
('django.middleware.common.CommonMiddleware',
 'django.middleware.doc.XViewMiddleware',
 'django.middleware.locale.LocaleMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware')


Traceback:
File "/usr/lib/python2.5/site-packages/django/core/handlers/base.py" in
get_response
  82.                 response = callback(request, *callback_args,
**callback_kwargs)
File "/usr/local/reviewboard/djblets/auth/util.py" in _checklogin
  45.             return view_func(request, *args, **kwargs)

Exception Type: TypeError at /r/1/publish/
Exception Value: new_decorator() got an unexpected keyword argument
'review_request_id'
chipx86
#1 chipx86
  • -Priority-Medium
    +Priority-Critical
    +Component-Reviews
  • +david
#3 rlo***@gmai***** (Google Code) (Is this you? Claim this profile.) 
I've also had the same problem

Environment:

Request Method: GET
Request URL: http://192.168.0.33:8000/r/1/publish/
Django Version: 0.97-pre-SVN-unknown
Python Version: 2.5.1
Installed Applications:
['django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.markup',
 'django.contrib.sites',
 'django.contrib.sessions',
 'djblets.datagrid',
 'djblets.util',
 'djblets.webapi',
 'reviewboard.accounts',
 'reviewboard.admin',
 'reviewboard.diffviewer',
 'reviewboard.iphone',
 'reviewboard.reports',
 'reviewboard.reviews',
 'reviewboard.scmtools',
 'reviewboard.webapi']
Installed Middleware:
('django.middleware.common.CommonMiddleware',
 'django.middleware.doc.XViewMiddleware',
 'django.middleware.locale.LocaleMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware')


Traceback:
File "/usr/lib/python2.5/site-packages/django/core/handlers/base.py" in get_response
  82.                 response = callback(request, *callback_args, **callback_kwargs)
File "/home/repo/reviewboard/djblets/auth/util.py" in _checklogin
  45.             return view_func(request, *args, **kwargs)

Exception Type: TypeError at /r/1/publish/
Exception Value: new_decorator() got an unexpected keyword argument 'review_request_id'
#4 ian.****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Same problem:

Environment:

Request Method: GET
Request URL: http://xxx:8000/r/1/publish/
Django Version: 0.97-pre-SVN-unknown
Python Version: 2.5.1
Installed Applications:
['django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.markup',
 'django.contrib.sites',
 'django.contrib.sessions',
 'djblets.datagrid',
 'djblets.util',
 'djblets.webapi',
 'reviewboard.accounts',
 'reviewboard.admin',
 'reviewboard.diffviewer',
 'reviewboard.iphone',
 'reviewboard.reports',
 'reviewboard.reviews',
 'reviewboard.scmtools',
 'reviewboard.webapi']
Installed Middleware:
('django.middleware.common.CommonMiddleware',
 'django.middleware.doc.XViewMiddleware',
 'django.middleware.locale.LocaleMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware')


Traceback:
File "/usr/lib/python2.5/site-packages/django/core/handlers/base.py" in get_response
  82.                 response = callback(request, *callback_args, **callback_kwargs)
File "/home/xxx/reviewboard/reviewboard/djblets/auth/util.py" in _checklogin
  45.             return view_func(request, *args, **kwargs)

Exception Type: TypeError at /r/1/publish/
Exception Value: new_decorator() got an unexpected keyword argument 'review_request_id'
david
#5 david
  • +Fixed