4796: CppCheck fails to run, typo in keyword arguments


What version of Review Board are you running?


What version of Review Bot are you running?

What tool(s) is Review Bot running?

CppCheck - v1.0

What steps will reproduce the problem?

  1. Enable cppcheck integration
  2. Publish review request to trigger check

What is the expected output? What do you see instead?

The check should run, instead the tool fails.

reviewbot_1 | [2019-02-19 13:24:43,945: ERROR/Worker-2] reviewbot.tasks.RunTool[ba1f945f-e52d-4e50-8b5e-aa7dc2d7b6c5]: Error executing tool "Cppcheck": execute() got an unexpected keyword argument 'ingore_errors' (server=http://mydomain.com/ReviewBoard/, review_request_id=806, diff_revision=3)
reviewbot_1 | Traceback (most recent call last):
reviewbot_1 | File "/usr/local/lib/python2.7/site-packages/reviewbot/tasks.py", line 185, in RunTool
reviewbot_1 | base_commit_id=base_commit_id)
reviewbot_1 | File "/usr/local/lib/python2.7/site-packages/reviewbot/tools/init.py", line 61, in execute
reviewbot_1 | self.handle_files(review.files, settings)
reviewbot_1 | File "/usr/local/lib/python2.7/site-packages/reviewbot/tools/init.py", line 77, in handle_files
reviewbot_1 | self.handle_file(f, settings)
reviewbot_1 | File "/usr/local/lib/python2.7/site-packages/reviewbot/tools/cppcheck.py", line 133, in handle_file
reviewbot_1 | output = execute(cppcheck_args, split_lines=True, ingore_errors=True)
reviewbot_1 | TypeError: execute() got an unexpected keyword argument 'ingore_errors'

Please provide any additional information below.

Notice the typo ingore rather than ignore...

#1 Misery

Fixed by https://github.com/reviewboard/ReviewBot/commit/edc7f2c77292708ea3da55e8d044c3e1af2cbd62

#2 peterh


#3 david
  • -New