4770: Review request draft view appears only for review request owner, even if other users are granted permission

cyran.norbert

What version are you running?

3.0.10

What's the URL of the page containing the problem?

/r/{id}

What steps will reproduce the problem?

  1. Create a review request
  2. As admin, grant all permissions to review requests, diffviewer and drafts for other user
  3. Log in to another user (with permissions)
  4. Upload new diff to the review request

What is the expected output? What do you see instead?

Green div informing that review request is a draft should be displayed. Instead there is not even any info about diff being successfully uploaded, and user with permissions can't update the review request from web app.

What operating system are you using? What browser?

OS and browser independent

Please provide any additional information below.

Publishing draft through API/rbt is workaround for this problem but it's very inconvenient to manually send requests to API every time you want update the review request of which you are not owner. Fact that user can publish draft through API proves that it's not a permissions issue.

tl;dr

User can't publish review request draft from browser. He is not an owner of a review request, but he has permission to do that.

david
#1 david
  • -New
    +PendingReview