What steps will reproduce the problem?
1. Create a change with a file named "foo++bar"
2. Try to submit the review using post-review.
What is the expected output? What do you see instead?
Expected: The review is posted
Actual: An error message:
Traceback (most recent call last):
File "/mts/home1/zhirsch/bin/post-review", line 452, in <module>
main()
File "/mts/home1/zhirsch/bin/post-review", line 448, in main
tempt_fate(changenum, repository_path, client_root)
File "/mts/home1/zhirsch/bin/post-review", line 390, in tempt_fate
upload_diff(review_request, changenum)
File "/mts/home1/zhirsch/bin/post-review", line 366, in upload_diff
diff_content = generate_diff(changenum)
File "/mts/home1/zhirsch/bin/post-review", line 298, in generate_diff
m = re.match(r'\+?%s \/\/.+ (.+)$' % depot_path, where_info)
File "/usr/lib/python2.5/re.py", line 137, in match
return _compile(pattern, flags).match(string)
File "/usr/lib/python2.5/re.py", line 241, in _compile
raise error, v # invalid expression
sre_constants.error: multiple repeat
What operating system are you using? What browser?
64-bit Ubuntu 8.04
Please provide any additional information below.
This seems to be related to the ++ in the filename interacting badly with
regexes. This message
http://mail.python.org/pipermail/tutor/2003-November/026127.html seems to
be about the same problem.
