4753: rbt diff output raw string

totoroliu

What version of Review Board are you running?

RBTools 1.0.1
svn, version 1.9.7 (r1800392)
Python 3.6.6

What version of RB Gateway are you running?

ReviewBoard 2.5.17

What repository type(s) are you using?

svn, version 1.9.7 (r1800392)

What steps will reproduce the problem?

  1. SVN commit a text file with content:
$ cat Test/test1
line1
line2
line3
line4
line5

  1. Replace line3 with "new line3"

  2. svn diff output:

Index: Test/test1
===================================================================
--- Test/test1  (revision 26385)
+++ Test/test1  (working copy)
@@ -1,5 +1,5 @@
 line1
 line2
-line3
+new line3
 line4
 line5

  1. rbt diff output:
$ rbt diff
b'Index: /TestProject/trunk/Test/test1\n===================================================================\n--- /TestProject/trunk/Test/test1\t(revision 26385)\n+++ /TestProject/trunk/Test/test1\t(working copy)\n@@ -1,5 +1,5 @@\n line1\n line2\n-line3\n+new line3\n line4\n line5\n'

What is the expected output? What do you see instead?

Ubuntu 16.04.5
RBTools 1.0.1
svn, version 1.9.9 (r1835931)
Python 2.7.14

$ svn diff
Index: Test/test1
===================================================================
--- Test/test1  (revision 26385)
+++ Test/test1  (working copy)
@@ -1,5 +1,5 @@
 line1
 line2
-line3
+new line3
 line4
 line5

$ rbt diff
Index: /TestProject/trunk/Test/test1
===================================================================
--- /TestProject/trunk/Test/test1   (revision 26385)
+++ /TestProject/trunk/Test/test1   (working copy)
@@ -1,5 +1,5 @@
 line1
 line2
-line3
+new line3
 line4
 line5

Please provide any additional information below.

Ubuntu 18.04.1
RBTools 1.0.1
svn, version 1.9.7 (r1800392)
Python 3.6.6

totoroliu
#1 totoroliu

Please ignore this bug.
I created this bug under wrong project.
I have recreated a new bug #4754

david
#2 david
  • -New
    +Invalid