4734: post-receive hooks can prematurely close review request

splatter2

What version of Review Board are you running?

3.0.8

What version of RB Gateway are you running?

1.0.0

What repository type(s) are you using?

Git

What steps will reproduce the problem?

  1. Commit changes to a local branch
  2. Create Review Request (rbt post)
  3. Push branch (git push -u origin myFeatureBranch)

What is the expected output? What do you see instead?

Review request is closed by the rb-gateway post-receive hook. This should not happen since:
1) The review has not been approved (no ShipIt).
2) The branch was pushed as a feature branch and not merged to baseline.

Please provide any additional information below.