4710: flake8 passes if executing command fails


What version of Review Board are you running?


What version of Review Bot are you running?


What tool(s) is Review Bot running?


What steps will reproduce the problem?

  1. Set up machine such that flake8 will fail to complete due to an exception (in my case pycodestyle dependency was too new)
  2. Set up machine to automatically review with flake8
  3. Post a review with code which should fail the flake8 bot.
  4. flake8 passes

What is the expected output? What do you see instead?

Expected flake8 to have status "error". Saw it passing.

Please provide any additional information below.

#1 jcannon

Review is at https://reviews.reviewboard.org/r/10048/

#2 david

Fixed in release-1.0.x (3e35fcf). This will ship in Review Bot 1.0.1. Thanks!

  • -New