4657: submit_as for diff updates

Misery

What version are you running?

3.0.3

What's the URL of the page containing the problem?

WebAPI

What steps will reproduce the problem?

  1. Create a user (A) with submit_as rights
  2. Create a review request with that user for another user (B)
  3. Review request shows (B) as submitter/owner
  4. Add a diff update as submit_as user (A) to same review request

What is the expected output? What do you see instead?

Changes are made by the current submit_as user instead of the real user with submit_as rights.

Expected:
Update is shown as user B.

See:
Update is shown as user A (submit_as rights).

What operating system are you using? What browser?

Linux, Firefox

Please provide any additional information below.

I already told it in mailling list. Just to have a bug report for this. :-)

~/.reviewboard
USERNAME='A'
API_TOKEN='ABC'

rbt post -r 9407 --submit-as B -p tip

Creating a review request works. But updates will happen with "A" instead of "B".

This is a missing WebAPI field in RB 3.0 since it supports switching the owner of review request.

https://groups.google.com/forum/#!topic/reviewboard-dev/OyngShI9nNM

Misery
#1 Misery

Fixed by ec7dc5c6ee3164b51e99809addbcef5c57355eb5 in RB 3.0.6

Still failing for "close review request" by submit_as as the "logged in user" is still used for that. That's ok for us but maybe someone wants this, too.

Misery
#2 Misery

https://github.com/reviewboard/reviewboard/blob/ec7dc5c6ee3164b51e99809addbcef5c57355eb5/reviewboard/webapi/resources/review_request.py#L925