4651: Line number 0 is never recognized


What version of Review Board are you running?


What version of Review Bot are you running?


What tool(s) is Review Bot running?


What steps will reproduce the problem?

  1. Create a cpp/h file without a copyright header
  2. Upload to RB
  3. See that cpplint do not mark an issue for the missing copyright

What is the expected output? What do you see instead?

Add a "general comment issue" for line 0 issues.

Please provide any additional information below.

cpplint prints out line 0 for missing copyright. The reviewbot will ignore that as no one can change line 0.

cpplint output:

main.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]

#1 Misery

It should be possible to add a general issue that will be displayed even if "comment on unmodified" is enabled. Example: clang-tidy tries to analyse the file but cannot finish the check because of compilation error. It should be reported as a general issue because the error could happen on unmodified line (as a result of another change). So it should show the compilation error for this.

#2 misery


#3 jcannon

This is what I see after running a tool that comments with first_line=0

#4 jcannon

Review for fix here: https://reviews.reviewboard.org/r/10093/

#5 david

Fixed in release-1.0.x (90e75f9). This will ship in 1.0.2. Thanks!

  • -New