4623: Change in newline at end of file provokes patch rejection / error

retinkab 
What version are you running?


Reviewboard 3.0.1


What steps will reproduce the problem?


    

  1. Upload patch
    2. 

  2. Upload updated patch to same review
    3. 





Consider a patch, generated on Linux. Someone adds a newline to the end of the file. You get in the patch file, (from the .diff file)

-)

\ No newline at end of file

+)


Reviewboard seems to be unaware of how to handle this, and tries to apply a patch that looks like: (from the .rej file)

-)+)


This results in a rejection being created, and a message allowing you to view or download the results of the rejected patch.


What operating system are you using?


Linux.
CMakeLists.txt.diff 
diff --git a/src/vision/camera_field_calibration/CMakeLists.txt b/src/vision/camera_field_calibration/CMakeLists.txt
index 0cdfbf068c5744d427f23b12723665af57138e8e..55437a5de288356009d2106abf7a596dacd9e96b 100644
--- a/src/vision/camera_field_calibration/CMakeLists.txt
+++ b/src/vision/camera_field_calibration/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 2.8.3)
+cmake_minimum_required(VERSION 3.0.2)
 project(camera_field_calibration)
 
 find_package(catkin REQUIRED COMPONENTS
@@ -46,4 +46,4 @@ install(
   DIRECTORY scripts/
   DESTINATION ${CATKIN_PACKAGE_BIN_DESTINATION}
   USE_SOURCE_PERMISSIONS
-)
\ No newline at end of file
+)
CMakeLists.txt.rej 
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -46,4 +46,4 @@ install(
   DIRECTORY scripts/
   DESTINATION ${CATKIN_PACKAGE_BIN_DESTINATION}
   USE_SOURCE_PERMISSIONS
-)+)