460: Wrong form error message on 'Base Diff Path' missing (svn)

ngu***@gmai***** (Google Code) (Is this you? Claim this profile.)
david
david
May 18, 2008
What's the URL of the page containing the problem?
http://localhost:8088/r/new/

What steps will reproduce the problem?
1. being logged in click on the "New Review Request"
2. select a diff file for the 'Diff' field, put nothing to the 'Base Diff Path'
3. click on the 'Create Review Request'

What is the expected output? What do you see instead?

Honestly speaking, I would expect a new request to be created as there are
no indication that Base Diff Path is a required field. Alternatively, I
would expect to see a clear message, something like 'this field is
required' near the "Base Diff Path" input field. 

What I see instead is "'UploadDiffForm' object has no attribute
'cleaned_data'" message right next to the "Diff" input field ( see
attachment ).


What operating system are you using? What browser?

Linux ngubuntu 2.6.22-14-generic #1 SMP Tue Feb 12 07:42:25 UTC 2008 i686
GNU/Linux
Checked against FireFox 2.0.0.13 , 3.0b4 and Opera 9.27. Do not think it is
browser specific though.

Please provide any additional information below.

Subversion repository is used
svn revision of the reviewboard is 1264
that of django source is 7403

thanks
david
#1 david
  • +Started
  • +david
david
#2 david
Fixed in r1364.  Thanks!
  • -Started
    +Fixed