mconley

4594: conditionSetViewTests.es6.js tests are currently failing in Firefox

mconley 
What version of Djblets are you using?


0.10.x branch


Which module(s) have the problem?


Forms




What steps will reproduce the problem?


    

  1. Run Review Board local server
    2. 

  2. Browse to http://localhost:8080/js-tests
    3. 





What is the expected output? What do you see instead?


The tests should all pass. Instead, I see the following failures:




djblets forms views ConditionValueFormFieldView Rendering Loaded rows
Expected '<span><input name="my_conditions_value[0]" type="text"></span>' to be '<span><input type="text" name="my_conditions_value[0]"></span>'.
Expected '<span><input name="my_conditions_value[0]" type="text"></span>' to be '<span><input type="text" name="my_conditions_value[0]"></span>'.
    at stack (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1577:17)
    at buildExpectationResult (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1547:14)
    at expectationResultFactory (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:638:18)
    at Spec.prototype.addExpectationResult (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:330:29)
    at addExpectationResult (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:588:16)
    at Expectation.prototype.wrapCompare/< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1501:7)
    at (unknown) (conditionSetViewTests.es6.js:125:12)
    at attemptSync (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1886:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1874:9)
    at QueueRunner.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1859:5)
    at queueRunnerFactory (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:697:7)
    at Spec.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:359:5)
    at fn (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2479:32)
    at attemptAsync (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1916:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1871:9)
    at QueueRunner.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1859:5)
    at queueRunnerFactory (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:697:7)
    at fn (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2464:13)
    at attemptAsync (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1916:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1871:9)
    at QueueRunner.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1859:5)
    at queueRunnerFactory (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:697:7)
    at fn (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2464:13)
    at attemptAsync (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1916:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1871:9)
    at QueueRunner.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1859:5)
    at queueRunnerFactory (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:697:7)
    at fn (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2464:13)
    at attemptAsync (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1916:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1871:9)
    at attemptAsync/next< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1898:11)
    at once/< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1842:9)
    at onComplete (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2467:17)
    at clearStack (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:660:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1881:7)
    at attemptAsync/next< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1898:11)
    at once/< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1842:9)
    at onComplete (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2467:17)
    at clearStack (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:660:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1881:7)
    at attemptAsync/next< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1898:11)
    at once/< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1842:9)
    at onComplete (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2467:17)
Expected '<span><input name="my_conditions_value[1]" type="email"></span>' to be '<span><input type="email" name="my_conditions_value[1]"></span>'.
Expected '<span><input name="my_conditions_value[1]" type="email"></span>' to be '<span><input type="email" name="my_conditions_value[1]"></span>'.
    at stack (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1577:17)
    at buildExpectationResult (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1547:14)
    at expectationResultFactory (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:638:18)
    at Spec.prototype.addExpectationResult (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:330:29)
    at addExpectationResult (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:588:16)
    at Expectation.prototype.wrapCompare/< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1501:7)
    at (unknown) (conditionSetViewTests.es6.js:151:12)
    at attemptSync (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1886:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1874:9)
    at QueueRunner.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1859:5)
    at queueRunnerFactory (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:697:7)
    at Spec.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:359:5)
    at fn (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2479:32)
    at attemptAsync (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1916:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1871:9)
    at QueueRunner.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1859:5)
    at queueRunnerFactory (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:697:7)
    at fn (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2464:13)
    at attemptAsync (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1916:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1871:9)
    at QueueRunner.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1859:5)
    at queueRunnerFactory (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:697:7)
    at fn (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2464:13)
    at attemptAsync (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1916:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1871:9)
    at QueueRunner.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1859:5)
    at queueRunnerFactory (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:697:7)
    at fn (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2464:13)
    at attemptAsync (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1916:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1871:9)
    at attemptAsync/next< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1898:11)
    at once/< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1842:9)
    at onComplete (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2467:17)
    at clearStack (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:660:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1881:7)
    at attemptAsync/next< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1898:11)
    at once/< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1842:9)
    at onComplete (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2467:17)
    at clearStack (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:660:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1881:7)
    at attemptAsync/next< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1898:11)
    at once/< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1842:9)
    at onComplete (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2467:17)





and




djblets forms views ConditionValueFormFieldView Actions Add a new condition
Expected '<span><input name="my_conditions_value[0]" type="text"></span>' to be '<span><input type="text" name="my_conditions_value[0]"></span>'.
Expected '<span><input name="my_conditions_value[0]" type="text"></span>' to be '<span><input type="text" name="my_conditions_value[0]"></span>'.
    at stack (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1577:17)
    at buildExpectationResult (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1547:14)
    at expectationResultFactory (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:638:18)
    at Spec.prototype.addExpectationResult (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:330:29)
    at addExpectationResult (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:588:16)
    at Expectation.prototype.wrapCompare/< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1501:7)
    at (unknown) (conditionSetViewTests.es6.js:221:12)
    at attemptSync (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1886:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1874:9)
    at QueueRunner.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1859:5)
    at queueRunnerFactory (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:697:7)
    at Spec.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:359:5)
    at fn (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2479:32)
    at attemptAsync (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1916:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1871:9)
    at QueueRunner.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1859:5)
    at queueRunnerFactory (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:697:7)
    at fn (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2464:13)
    at attemptAsync (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1916:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1871:9)
    at attemptAsync/next< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1898:11)
    at once/< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1842:9)
    at onComplete (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2467:17)
    at clearStack (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:660:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1881:7)
    at attemptAsync/next< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1898:11)
    at once/< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1842:9)
    at complete (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:371:9)
    at clearStack (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:660:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1881:7)
    at QueueRunner.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1859:5)
    at queueRunnerFactory (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:697:7)
    at Spec.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:359:5)
    at fn (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2479:32)
    at attemptAsync (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1916:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1871:9)
    at attemptAsync/next< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1898:11)
    at once/< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1842:9)
    at complete (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:371:9)
    at clearStack (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:660:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1881:7)
    at QueueRunner.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1859:5)
    at queueRunnerFactory (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:697:7)
    at Spec.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:359:5)
    at fn (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2479:32)
    at attemptAsync (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1916:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1871:9)
    at QueueRunner.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1859:5)
    at queueRunnerFactory (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:697:7)
    at fn (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2464:13)
    at attemptAsync (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1916:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1871:9)
    at QueueRunner.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1859:5)
    at queueRunnerFactory (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:697:7)
    at fn (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2464:13)
    at attemptAsync (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1916:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1871:9)
    at QueueRunner.prototype.execute (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1859:5)
    at queueRunnerFactory (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:697:7)
    at fn (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2464:13)
    at attemptAsync (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1916:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1871:9)
    at attemptAsync/next< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1898:11)
    at once/< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1842:9)
    at onComplete (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2467:17)
    at clearStack (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:660:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1881:7)
    at attemptAsync/next< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1898:11)
    at once/< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1842:9)
    at onComplete (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2467:17)
    at clearStack (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:660:9)
    at QueueRunner.prototype.run (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1881:7)
    at attemptAsync/next< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1898:11)
    at once/< (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:1842:9)
    at onComplete (http://localhost:8080/static/lib/js/jasmine-2.4.1.js:2467:17)
mconley
#1 mconley 
Interestingly, these tests pass just fine in Chrome.


They fail in Firefox. Looks like an attribute ordering issue.
mconley
#2 mconley
  • -conditionSetViewTests.es6.js tests are currently failing
    +conditionSetViewTests.es6.js tests are currently failing in Firefox
ejohansson
#3 ejohansson 
I also ran into this and posted a suggested fix: https://reviews.reviewboard.org/r/9344/
david
#4 david 
Fixed in release-1.0.x (8525f39). This will ship in djblets 1.0.1. Thanks!
  • -New
    +Fixed