4578: Please add option to disable "send on behalf"

streamofstars
chipx86
chipx86

What version are you running?

2.5.13.1

Describe the enhancement and the motivation for it.

Please either add an option to disable sending on behalf or describe in documentation how I could do this myself in config/python files.

All emails sent by reviewboard are sent on behalf. This is a problem for me because all such emails go to junk mail folder in Outlook. I do not need info about the real sender at the email header level, this is known from the email body anyway. I would rather see all emails being send by the service account as they actually are.

chipx86
#1 chipx86

I'm open to adding it, though you can get what you want today by having a DMARC record for your domain that tells services not to allow sending on behalf of users. Review Board will accept this setting and send from a single configured e-mail address instead.

  • -New
    +Confirmed
  • +Component:EMail
chipx86
#2 chipx86
  • +EasyFix
bleblan2
#3 bleblan2

I'll take this bug

bleblan2
#4 bleblan2

Review request published.

david
#5 david

Fixed in release-3.0.x (b75e73c). This will ship in 3.0.13. Thanks!

  • -Confirmed
    +Fixed
chipx86
#6 chipx86

Sorry, this won't make the release. There's some regressions with this, so we're having to back it out.

  • -Fixed
    +Confirmed
  • -reviewboard
    +djblets
  • +chipx86
chipx86
#7 chipx86
  • +Release-1.0.x
chipx86
#8 chipx86

Scratch that. I've based a change off of the contribution that will retain the backwards-compatible behavior but allow for better control of From spoofing through a new parameter and setting. This should go into the upcoming release.

chipx86
#9 chipx86

Fixed on release-1.0.x (cf6dfe1e155493746abf94fa483ecec5f349b1a2). This will be part of the upcoming 1.0.10, and Review Board will have a setting for it in the E-Mail Settings page.

  • -Confirmed
    +Fixed