4549: No Review Request if more than 1 bug Id addressed upon commit

Pavel.German 
What version are you running?


Review Board 2.5.7


What's the URL of the page containing the problem?




What steps will reproduce the problem?


    

  1. Commit a bug and address 2 or more bug ids, separated by whitespace
    2. 

  2. Review is not issued (see an attached log with the exception)
    3. 





What is the expected output? What do you see instead?


Review is issued




What operating system are you using? What browser?


Windeos 7, both Chrome and IE




Please provide any additional information below.
tooManyRevisions.txt 
11:08:02 Total time: 10 seconds
11:08:02 Review request output
11:08:02 >>> RBTools 0.7.7
11:08:02 
11:08:02 >>> Python 2.6.6 (r266:84292, Aug 18 2016, 15:13:37) 
11:08:02 
11:08:02 [GCC 4.4.7 20120313 (Red Hat 4.4.7-17)]
11:08:02 
11:08:02 >>> Running on Linux-2.6.32-642.6.2.el6.x86_64-x86_64-with-centos-6.8-Final
11:08:02 
11:08:02 >>> Home = /home/opencm
11:08:02 
11:08:02 >>> Current directory = /opt/opencm/hudson/jobs/Worker6a/workspace/CR_FB_50311_2/skyboxview
11:08:02 
11:08:02 >>> Command line: rbt post -d -p --repository-type svn --server http://reviewboard --exclude /*skyboxview/test-data* --submit-as dbrener --description "Issue 50541 CP P1: Incorrect behavior in FW1RESTCollectorTask during the Rest collection flow" --summary "Issue 50541 CP P1: Incorrect behavior in FW1RESTCollectorTask during the Rest collection flow" --target-groups=Modeling --bugs-closed 50541 50551 --username opencm --password opencm
11:08:02 
11:08:02 >>> Checking for a Subversion repos
chipx86
#1 chipx86 
What's happening is that --bugs-closed 50541 50551 doesn't pass two values to --bugs-closed, it passes one. The 50551 is then passed as an argument to rbt post. What you need to do is encase the full list in quotes. Note that they must be comma-separated, though.


So, you want:


--bugs-closed "50541, 50551"
  • -reviewboard
    +rbtools
chipx86
#2 chipx86 
Your --exclude is going to have a similar problem. You'll need to encase it in quotes as well. Otherwise, the shell may expand that and turn it into multiple parameters. That in combination with --bugs-closed is what's leading to the TooManyRevisions (which needs to be handled better).
david
#3 david
  • -New
    +UserError