454: viewing diff of large changeset, did not complete, had exception

cch****@gmai***** (Google Code) (Is this you? Claim this profile.)
April 19, 2008 
What's the URL of the page containing the problem?
http://reviewboard.eng.vmware.com/r/19156/diff/#index_header

What steps will reproduce the problem?
1. create new rev request
2. add group and 2 people
3. click on view diff

What is the expected output? What do you see instead?
see the diff

What operating system are you using? What browser?
winxp sp2, mozilla firefox

Please provide any additional information below.

Error message:


The patch to
'E:/vc-testware-u2/staf/tests/VC/STAX/systemtest/framework/GeneralServiceConstants.xml'
didn't apply cleanly. The temporary files have been left in
'/tmp/reviewboard.CpVosV' for debugging purposes. newfile:
/tmp/reviewboard.CpVosV/tmpGzzCIu-new, oldfile:
/tmp/reviewboard.CpVosV/tmpGzzCIu, diff: /tmp/reviewboard.CpVosV/tmpFxeMXh.
`patch` returned: patching file /tmp/reviewboard.CpVosV/tmpGzzCIu .

Traceback (most recent call last):
  File "/root/reviewboard/diffviewer/views.py", line 81, in view_diff
    files = get_diff_files(diffset, None, interdiffset, highlighting)
  File "/root/reviewboard/diffviewer/diffutils.py", line 569, in get_diff_files
    enable_syntax_highlighting)
  File "/root/reviewboard/diffviewer/diffutils.py", line 508, in generate_files
    lambda: get_chunks(filediff.diffset,
  File "/root/reviewboard/djblets/util/misc.py", line 47, in cache_memoize
    data = lookup_callable()
  File "/root/reviewboard/diffviewer/diffutils.py", line 511, in <lambda>
    enable_syntax_highlighting))
  File "/root/reviewboard/diffviewer/diffutils.py", line 307, in get_chunks
    new = get_patched_file(old, filediff)
  File "/root/reviewboard/diffviewer/diffutils.py", line 220, in
get_patched_file
    return patch(filediff.diff, buffer, filediff.dest_file)
  File "/root/reviewboard/diffviewer/diffutils.py", line 117, in patch
    p.stdout.read()))
Exception: The patch to
'E:/vc-testware-u2/staf/tests/VC/STAX/systemtest/framework/GeneralServiceConstants.xml'
didn't apply cleanly. The temporary files have been left in
'/tmp/reviewboard.CpVosV' for debugging purposes.
newfile: /tmp/reviewboard.CpVosV/tmpGzzCIu-new, oldfile:
/tmp/reviewboard.CpVosV/tmpGzzCIu, diff: /tmp/reviewboard.CpVosV/tmpFxeMXh.
`patch` returned: patching file /tmp/reviewboard.CpVosV/tmpGzzCIu
.
chipx86
#1 chipx86 
Did you create the review request through the web UI or post-review?

Can you verify that the repository listed on the review request page is the same as
your checkout?
  • +NeedInfo
#2 cch****@gmai***** (Google Code) (Is this you? Claim this profile.) 
E:\vc-testware-u2\staf\tests\VC\ is the dir i'm trying to add my integration into. 
I created teh rev request through the web UI
chipx86
#3 chipx86 
The directory doesn't really tell me anything. I need to know if the Perforce
repository matches the one listed on the review request.
#4 cch****@gmai***** (Google Code) (Is this you? Claim this profile.) 
//depot/staf/vc-testware-u2/tests/ is the depot directory, where i'm trying to add
the .../vc/... files.
chipx86
#5 chipx86 
It doesn't look like you specified the right perforce server when you were uploading
the review request. Can you e-mail me with the contents of:

p4 info

(Run it from your checkout directory)
#6 cch****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Server address: perforce-qa.eng.vmware.com:1666
Server root: /p4d/perforce_1666
chipx86
#7 chipx86 
This may be due to the newline issue we hit. I don't think the server's been upgraded
for this.

First, check to make sure that you are fully synced and this file doesn't exist in
the repository.

Second, open the file and add a blank line to the end of it.

See if that helps.
david
#8 david 
I'm going to assume this is no longer an issue -- the VMware install has been updated
to the latest codebase, and it's been needinfo for a couple weeks.  Please add a
comment and we'll reopen this if you encounter it again.
  • -NeedInfo
    +Fixed