4515: git-svn support broken in setup-repo

mkmaier
brennie
brennie

What version are you running?

RBTools 0.7.9
Python 2.7.12

What steps will reproduce the problem?

  1. "rbt setup-repo" in git-svn root directory
  2. enter repo url

What is the expected output? What do you see instead?

Should initialize git-svn repo, but shows python error instead.
After "fixing" the error by removing the offending keyword, git-svn only offers the git repos on the rb server, instead of the svn repo.

What operating system are you using?

Cygwin on Windows 10

Attach the debug out from the command.

$ rbt setup-repo -d
>>> RBTools 0.7.9
>>> Python 2.7.12 (default, Oct 10 2016, 12:56:26)
[GCC 5.4.0]
>>> Running on CYGWIN_NT-10.0-2.6.1-0.305-5-3-x86_64-64bit
>>> Home = /home/me
>>> Current directory = /cygdrive/c/workspaces/company.git
>>> Command line: rbt setup-repo -d
Enter the Review Board server URL: http://reviewboard.company.com/reviewboard/
>>> Checking for a Subversion repository...
>>> Running: svn --non-interactive info
>>> Command exited with rc 1: ['svn', '--non-interactive', u'info']
svn: E155007: '/cygdrive/c/workspaces/company.git' is not a working copy
---
>>> Checking for a Git repository...
>>> Running: git rev-parse --git-dir
>>> Running: git config core.bare
>>> Running: git rev-parse --show-toplevel
>>> Running: git symbolic-ref -q HEAD
>>> Running: git svn info
>>> Running: git svn rebase -n
Traceback (most recent call last):
  File "/usr/bin/rbt", line 11, in <module>
    sys.exit(main())
  File "/usr/lib/python2.7/site-packages/rbtools/commands/main.py", line 133, in main
    command.run_from_argv([RB_MAIN, command_name] + args)
  File "/usr/lib/python2.7/site-packages/rbtools/commands/__init__.py", line 664, in run_from_argv
    exit_code = self.main(*args) or 0
  File "/usr/lib/python2.7/site-packages/rbtools/commands/setup_repo.py", line 104, in main
    repository_info, tool = self.initialize_scm_tool()
  File "/usr/lib/python2.7/site-packages/rbtools/commands/__init__.py", line 693, in initialize_scm_tool
    client_name=client_name)
  File "/usr/lib/python2.7/site-packages/rbtools/clients/__init__.py", line 426, in scan_usable_client
    repository_info = tool.get_repository_info()
  File "/usr/lib/python2.7/site-packages/rbtools/clients/git.py", line 278, in get_repository_info
    supports_parent_diffs=True)
TypeError: __init__() got an unexpected keyword argument 'supports_parent_diffs'

Please provide any additional information below.

brennie
#1 brennie

A fix for this issue has already landed in the release-0.7.x branch of RBTools as 9b01fa5. It will be included in the next release of RBTools. The patch is available at https://reviews.reviewboard.org/r/8662/.

  • -New
    +Fixed
  • +brennie