4513: User selector in the Group configuration breaks for non-active users
- Fixed
- Review Board
chipx86 | |
|
What version are you running?
2.5.7
What's the URL of the page containing the problem?
/admin/db/reviews/group/ID/
What steps will reproduce the problem?
- Add another user to a group.
- Go into the Users part of the database viewer, edit a user, and uncheck the "Active" checkbox. Save.
- Try to save the group again.
What is the expected output? What do you see instead?
This will fail with "Select a valid choice. ID is not one of the available choices."
This happens because the queryset for
GroupForm
usesis_active=True
, preventing any users in the list who are inactive from being saved.We should remove that and make sure inactive users in the list can be saved (with a unit test proving this).