450: Include an offset on file numbers in paginated diffviewer page

gcmc****@yaho***** (Google Code) (Is this you? Claim this profile.)
david
david
Sept. 28, 2008
What's the URL of the page containing the problem?

diff viewer page


What steps will reproduce the problem?
1. create a review larger than DIFFVIEWER_PAGINATE_BY size
2. go to 2nd page of the diffs
3.

What is the expected output? What do you see instead?

The counters to the left of the filename links in the
templates/diffviewer/changeindex.html should probably not start at one. 
Rather they should somehow reference file.index+1

What operating system are you using? What browser?


Please provide any additional information below.
chipx86
#1 chipx86
  • -Type-Defect
    +Type-Enhancement
    +Component-DiffViewer
chipx86
#2 chipx86
Should be an easy 1.0 fix.
  • +Milestone-Release1.0
chipx86
#3 chipx86
  • +EasyFix
david
#4 david
  • +Started
  • +david
david
#5 david
Fixed in SVN r1516. Thanks!
  • -Started
    +Fixed