4473: Inter-diff compares don't work when the file path doesn't exactly match.

TheHackmeister

What version are you running?

Reviewboard - 2.5.6.1
OS - Centos 7

What steps will reproduce the problem?

  1. Setup a SVN repository to work with reviewboard
  2. Upload a diff and use a base dir with "/"s. For example, I used "/trunk/"
  3. Save the review.
  4. Upload an updated diff and use a base dir with "\"s. For example, I used "\trunk\".
  5. Then view the changes between revision 1 and 2.

What is the expected output? What do you see instead?

I see the same file listed twice, with the file from step 4 showing up with "//" instead of "/".
What I should see is 1 file.

What operating system are you using? What browser?

Windows 10. Have tried it Opera, Firefox, and Chrome.

Please provide any additional information below.

#2 jamie
  • +Release-2.5.x
  • +Interdiffs
#3 jamie
  • +Component:DiffViewer
#4 jamie
  • +SCM:Subversion