volo.zyko

4408: When creating a new review request make arbitrary field required

volo.zyko 
What version are you running?


2.0.20


Describe the enhancement and the motivation for it.


In our project people always forget to specify mercurial branch from which they create a patch. In other projects other fields can be important.


Also, very few of us use RBT, as its command line interface is a bit complicated. So, in this ticket I mean manual patch upload.


What operating system are you using? What browser?


Linux/MacOS. Chrome/Firefox.
volo.zyko
#1 volo.zyko 
BTW, adding is_required = True to BranchField in reviewboard/reviews/builtin_fields.py didn't help. So, what else should we change.
brennie
#2 brennie 
This would be better done as an extension as that field will not be checked.


You can set up a SignalHook that will listen for the reviewboard.reviews.signals.review_request_publishing signal and throw a reviewboard.reviews.errors.PublishError if the branch field is not filled out.


You can look at this guide on extending Review Board for help on writing extensions.
  • -New
    +NotABug