440: Not all texts are marked as translation strings

hfu***@gmai***** (Google Code) (Is this you? Claim this profile.)
March 29, 2008 
I am traslating entire this tool into japanese
but some texts are marked as normal strings.

These should be marked as translation strings, including js files if possible.
david
#1 david 
Can you update this bug with references to unmarked strings as you find them?
#3 hfu***@gmai***** (Google Code) (Is this you? Claim this profile.) 
I made a patch file for this bug.
What I do is to mark normal strings as translation strings.
My site seems to be good to work with this patch now.
  • +
    review_board_trans.diff 
    Index: reviews/models.py
    ===================================================================
    --- reviews/models.py	(revision 1233)
    +++ reviews/models.py	(working copy)
    @@ -240,9 +240,9 @@
         internal state.
         """
         STATUSES = (
    -        ('P', 'Pending Review'),
    -        ('S', 'Submitted'),
    -        ('D', 'Discarded'),
    +        ('P', _('Pending Review')),
    +        ('S', _('Submitted')),
    +        ('D', _('Discarded')),
         )
     
         submitter = models.ForeignKey(User, verbose_name=_("submitter"),
    Index: diffviewer/diffutils.py
    ===================================================================
    --- diffviewer/diffutils.py	(revision 1233)
    +++ diffviewer/diffutils.py	(working copy)
    @@ -526,7 +526,7 @@
                     dest_revision = "Diff Revision %s" % interdiffset.revision
             else:
                 source_revision = get_revision_str(filediff.source_revision)
    -            dest_revision = "New Change"
    +            dest_revision = _("New Change")
     
             i = filediff.source_fil
david
#4 david 
Can you upload this to http://reviews.review-board.org ?   Thanks!
david
#5 david
  • +Fixed