424: hard-coded URLs prevent changing root URL
- Fixed
- Review Board
| edg****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| April 15, 2008 |
When attempting to get reviewboard to handle a base URL like
"http://example.com/reviewboard", I created a wrapper urls.py file which
looks like:
-------------------
from django.conf.urls.defaults import patterns, include
urlpatterns = patterns('',
(r'^reviewboard/', include('urls_main')),
)
-------------------
and copied the original urls.py to urls_main.py.
This *SHOULD* work, allowing one to easily switch the base URL for
accessing the reviewboard system. But, because there are hardcoded URLs
(not only those in the original urls.py file), this is currently not
possible to do.
For example, even after changing all of the hardcoded URLs in urls_main.py,
the browser is redirected at some point to /account/login (though it should
be /reviewboard/account/login).
Work is being done on this and there's a review request up for it. It'll be committed once some other things are in.
-
- Priority-Medium + Priority-High + Milestone-Release1.0 + Component-Deployment
This should now be in SVN. You can configure the site root by setting the SITE_ROOT variable in settings_local.py. For example: SITE_ROOT = "/reviewboard/"
-
+ Fixed
It seems that most things are fixed by the changes. However, with SVN rev. 1233, I still have a few problems: - in the 'all review requests' list, clicking on a submitter name is broken (omits SITE_ROOT) - on the review-detail page, clicking on the submitter is broken (has an extra '/' after SITE_ROOT). - on the submitters page, clicking on a submitter is broken (has an extra '/' after SITE_ROOT). - on the 'my dashboard' page, all of the links in the left column are broken (there is an extra '/dashboard' in them.
almost fixed. I still noticed one issue with clicking on a user name from the "review requests for [group-name]" page. So, to get there, click on a group name. Then, in the list of associated reviews, click on one of the submitter names. You will then get the error: The requested URL /users/<username>/ was not found on this server. (if you use a URL namespace prefix).