419: Be smarter about showing trailing whitespace changes
- Fixed
- Review Board
| jameslin | |
 |
|
| Jan. 29, 2009 |
1. In comments within code (e.g. "/* C-style comment */" or "// C++ style comment"), changes to trailing whitespace show up as changes in the diff, but because trailing whitespace in those cases isn't highlighted in red blocks, it's not apparent what changed. 2. It might be nice to if changes that remove trailing whitespace were ignored in the diff completely. They can add a lot of clutter. (Adding trailing whitespace probably should still be indicated, though.)
Also, I have a change to C code where there's a line: #ifdef _WIN32 which had trailing whitespace that I removed. It shows up as a change in the Reviewboard diff, but the trailing whitespace isn't shown, so once again it's confusing to reviewers what was altered.
For me reviewboard always shows trailing whitespace at the end of a line in big bold red. I find this very distracting and I don't see why it is necessary. If the line hasn't changed, who cares about the whitespace. If the line ending has changed, show the difference using the standard bold yellow. To highlight the trailing whitespace on new lines highlight it with bold green.
If seeing the spaces is important, why not replace them all with something like "·" = "·" = "·"
-
- Type-Defect + Type-Enhancement + Component-DiffViewer
-
+ Confirmed
Fixed this a couple days ago, but I didn't see the bug. It'll be in alpha 2.
-
- Confirmed + Fixed -
+ Milestone-Release1.0 -
+ chipx86