4130: Find a way of showing comments that intersect the same codelines without repeating context

mconley

What version are you running?

2.5.2

What's the URL of the page this enhancement relates to, if any?

Any reviews page.

Describe the enhancement and the motivation for it.

Suppose in the diffviewer, you select some lines 1-50 of a patch to comment on. Then, within that same file, suppose you comment on lines 25-28.

When the review is published, in the "reviews" page, we'll see two separate comments in the review, each showing the lines that were selected, but isolated from one another.

It might be worth trying to find a way of making it clearer that the second comment on lines 25-28 also apply on top of the comments on lines 1-50. This is apparent when looking at the diff, but not so much when looking at the reviews.

What operating system are you using? What browser?

OS X, Firefox Nightly 47.0a1

Please provide any additional information below.

david
#1 david

I don't think this is something that's worth spending time on. In most cases, people are looking at a single opened issue at a time, with interruptions and delays thrown in. If two comments are truly related and interconnected, it's best that the reviewer mention that in their text.

  • -New
    +WontFix