What steps will reproduce the problem?
1. Post a review request using post-review <filename>
2. Publish, get comments, update <filename>
3. Update request with post-review --review-request-id 3 <filename>
What is the expected output? What do you see instead?
I'd expect a new diff attached to the existing review ID 3. Instead, I get
an error output:
Traceback (most recent call last):
File "/home/rolandec/bin/post-review", line 853, in ?
main(sys.argv[1:])
File "/home/rolandec/bin/post-review", line 835, in main
review_url = tempt_fate(server, tool, changenum, files, diff_content=diff)
File "/home/rolandec/bin/post-review", line 651, in tempt_fate
review_request = server.get_review_request(options.rid)
File "/home/rolandec/bin/post-review", line 135, in get_review_request
rsp = self.api_get('/api/json/reviewrequests/%s/' % id)
File "/home/rolandec/bin/post-review", line 207, in api_get
return self.process_json(self.http_get(path))
File "/home/rolandec/bin/post-review", line 191, in http_get
rsp = urllib2.urlopen(url).read()
File "/usr/lib/python2.4/urllib2.py", line 130, in urlopen
return _opener.open(url, data)
File "/usr/lib/python2.4/urllib2.py", line 350, in open
protocol = req.get_type()
File "/usr/lib/python2.4/urllib2.py", line 233, in get_type
raise ValueError, "unknown url type: %s" % self.__original
ValueError: unknown url type: /api/json/reviewrequests/3/
What operating system are you using? What browser?
Gentoo Linux, Python 2.4.2
Please provide any additional information below.
Quite possibble I misunderstood the update existing request feature with a
new diff. Am I using this as intended?
